linux-kernel - RE: [PATCH] x86_64: remove check for CONSTANT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <249EE4DE927F114DBDC077FFA4A34DC701B3C700@SAUSEXMB3.amd.com>
Date:	Mon, 4 Jun 2007 17:23:01 -0500
From:	"Nagendra, Bhavana" <bhavana.nagendra@....com>
To:	"Roedel, Joerg" <Joerg.Roedel@....com>, "Andi Kleen" <ak@...e.de>
cc:	linux-kernel@...r.kernel.org,
	"Deguara, Joachim" <joachim.deguara@....com>
Subject: RE: [PATCH] x86_64: remove check for CONSTANT_TSC from time.c


Yes, the attached patch works for me.  Andi, is this patch acceptable?  

Regards,
--
Bhavana Nagendra
AMD, Inc
 
 

-----Original Message-----
From: Joerg Roedel [mailto:joerg.roedel@....com] 
Sent: Monday, June 04, 2007 4:42 PM
To: Andi Kleen
Cc: linux-kernel@...r.kernel.org; Deguara, Joachim; Nagendra, Bhavana
Subject: Re: [PATCH] x86_64: remove check for CONSTANT_TSC from time.c

On Mon, Jun 04, 2007 at 08:02:40PM +0200, Andi Kleen wrote:
> On Monday 04 June 2007 19:49, Joerg Roedel wrote:
> > From: Joerg Roedel <joerg.roedel@....com>
> >
> > This patch removes the check for the CONSTANT_TSC cpu flag from
time.c
> > on the x86_64 architecture. At the time this flag is checked at boot
the
> > cpu init code was yet not executed and thus the check fails. At this
> > point the check for VENDOR_AMD and cpu family 0x10 is sufficient.
> 
> Wrong fix. The bit just needs to be set earlier in early cpu detect.
Otherwise 
> there is a problem again with the next constant TSC AMD CPU.
> I will do that.
> 
> -Andi

Ok. But I assume you are meaning something like the attached diff?

Signed-off-by: Joerg Roedel <joerg.roedel@....com>

-- 
           |           AMD Saxony Limited Liability Company & Co. KG
 Operating |         Wilschdorfer Landstr. 101, 01109 Dresden, Germany
 System    |                  Register Court Dresden: HRA 4896
 Research  |              General Partner authorized to represent:
 Center    |             AMD Saxony LLC (Wilmington, Delaware, US)
           | General Manager of AMD Saxony LLC: Dr. Hans-R. Deppe,
Thomas McCoy


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/