linux-kernel - Re: joydev.c and saitek cyborg evo force

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d9b9d95f0706041546h4eef0b4eo2e191968be13d59a@mail.gmail.com>
Date:	Mon, 4 Jun 2007 23:46:28 +0100
From:	"Renato Golin" <rengolin@...il.com>
To:	"Jiri Kosina" <jkosina@...e.cz>
Cc:	linux-kernel@...r.kernel.org,
	"Dmitry Torokhov" <dmitry.torokhov@...il.com>
Subject: Re: joydev.c and saitek cyborg evo force

On 04/06/07, Jiri Kosina <jkosina@...e.cz> wrote:
> sorry, don't fully understand - what do you mean by "got the messages but
> not the fix"?

The range "detected" was 0 to 255 but both X and Y axis are reporting 4096.

I think that the code in drivers/hid/hid-input.c:
if ((device->quirks & HID_QUIRK_BADPAD) && (usage->code == ABS_X ||
usage->code == ABS_Y)) {
  a = field->logical_minimum = 0;
  b = field->logical_maximum = 255;
}

should get what's being reported from the device instead of hard-code
to 0 to 255 (which might not even be an unsigned range).


> Well calibration using jscal might be needed, that should be fine. The
> question is whether the ranges are now correct and calibration using jscal
> works fine.

Ok, so maybe in that case my automatic calibration is still worth to
put on joydev.c
and users from all joysticks in the quirk list would benefit.


> So please let me know whether the badpad quirk is the correct one for this
> joystick. If so, I'll queue it in my tree for upstream.

Well, it did the trick if that's what you mean but would be better to
get the correct range from start... But I don't know how difficult it
is, so maybe we'll have to stick with the automatic calibration
afterwards...

cheers,
--renato

Reclaim your digital rights, eliminate DRM, learn more at
http://www.defectivebydesign.org/what_is_drm
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/