linux-kernel - Re: [RFC] Documentation/CodingStyle: Add rules for goto labels (-v2)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 5 Jun 2007 09:37:36 +0800
From:	WANG Cong <xiyou.wangcong@...il.com>
To:	Jeremy Fitzhardinge <jeremy@...p.org>
Cc:	Sam Ravnborg <sam@...nborg.org>, Jeff Garzik <jeff@...zik.org>,
	Randy Dunlap <rdunlap@...otime.net>,
	Al Viro <viro@....linux.org.uk>,
	LKML <linux-kernel@...r.kernel.org>, akpm@...ux-foundation.org,
	Chen Li-jun <cljun@...ou.edu.cn>,
	Wang Ya-gang <lazy_linux@....com>
Subject: Re: [RFC] Documentation/CodingStyle: Add rules for goto labels (-v2)

On Mon, Jun 04, 2007 at 12:02:28PM -0700, Jeremy Fitzhardinge wrote:
>Sam Ravnborg wrote:
>> If local(__label__) really so widely used in the kernel that it deserves
>> a place in coding-style?
>> A quick grep did not say so.
>>   
>
>Probably not, and its use shouldn't be (even tacitly) encouraged.  It's
>only really useful for defining a local label within a macro, and
>there's probably something wrong with your macro if you need a local label.
>
>    J

I agree. Local labels maybe useful in macros.
If someone will use local labels in his code some day, we shouldn't force him
to align his labels in the first column.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/