linux-kernel - Re: [PATCH ext3/ext4] orphan list check on destroy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070604185420.b4206698.akpm@linux-foundation.org>
Date:	Mon, 4 Jun 2007 18:54:20 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Vasily Averin <vvs@...ru>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	devel@...nvz.org, linux-ext4@...r.kernel.org,
	Stephen Tweedie <sct@...hat.com>, adilger@...sterfs.com
Subject: Re: [PATCH ext3/ext4] orphan list check on destroy_inode

On Mon, 04 Jun 2007 09:18:55 +0400 Vasily Averin <vvs@...ru> wrote:

> Customers claims to ext3-related errors, investigation showed that ext3 orphan list has been corrupted and have the reference to non-ext3 inode. The following debug helps to understand the reasons of this issue.
> 
> Signed-off-by:	Vasily Averin <vvs@...ru>
> 
> diff --git a/fs/ext3/super.c b/fs/ext3/super.c
> index 6e30629..46e2fa6 100644
> --- a/fs/ext3/super.c
> +++ b/fs/ext3/super.c
> @@ -459,6 +459,21 @@ static struct inode *ext3_alloc_inode(struct super_block *sb)
>  
>  static void ext3_destroy_inode(struct inode *inode)
>  {
> +	if (!list_empty(&(EXT3_I(inode)->i_orphan))) {
> +		int i, imax;
> +		unsigned int *p;
> +
> +		p = (unsigned int *)EXT3_I(inode);
> +		imax = sizeof(struct ext3_inode_info) / sizeof(unsigned int);
> +		printk("Inode %p: orphan list check failed!\n", EXT3_I(inode));
> +		for (i = 0; i < imax; i++) {
> +			if (i && ((i % 8) == 0))
> +				printk("\n");
> +			printk("%08x ", *p++);
> +		}
> +		printk("\n");
> +		dump_stack();

umm, OK, but please use the new lib/hexdump.c for this.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/