linux-kernel - Re: [PATCH] UDF: coding style conversion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20070605182850.GD8398@cvg>
Date:	Tue, 5 Jun 2007 22:28:50 +0400
From:	Cyrill Gorcunov <gorcunov@...il.com>
To:	Joe Perches <joe@...ches.com>
Cc:	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] UDF: coding style conversion - lindent fixups 2

[Joe Perches - Tue, Jun 05, 2007 at 11:20:46AM -0700]
| On Tue, 2007-06-05 at 22:03 +0400, Cyrill Gorcunov wrote:
| > -			    cpu_to_le32(epos.offset -
| > -					sizeof(struct allocExtDesc));
| > -			if (!UDF_QUERY_FLAG(inode->i_sb, UDF_FLAG_STRICT)
| > -			    || UDF_SB_UDFREV(inode->i_sb) >= 0x0201)
| > +				cpu_to_le32(epos.offset -
| > +					    sizeof(struct allocExtDesc));
| > +			if (!UDF_QUERY_FLAG(inode->i_sb, UDF_FLAG_STRICT) ||
| > +			    UDF_SB_UDFREV(inode->i_sb) >= 0x0201)
| 
| Please do not move logical operators or tests from
| "beginning of next line" to "end of line".
| 
| It's coder taste and there is no style guide consensus for this.
| 
| cheers,
| 
| Joe
| 

Actually a such conversion were made by Lindent - not coder...
See for original truncate.c in current Linus's tree

		Cyrill

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/