linux-kernel - Re: [PATCH] lguest-fix-divide-error-implement-sched

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200706052051.02823.ak@suse.de>
Date:	Tue, 5 Jun 2007 20:51:02 +0200
From:	Andi Kleen <ak@...e.de>
To:	"H. Peter Anvin" <hpa@...or.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Rusty Russell <rusty@...tcorp.com.au>,
	Matt Mackall <mpm@...enic.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] lguest-fix-divide-error-implement-sched_clock


> 
> That's a vendor check foul.  That should be a CPU feature flag.
>
> Looks like there is some work to be done here.

No.

That would just move that code elsewhere, but there is still only
a single caller who actually uses this. Besides there are further
checks to be done here (see x86-64) which does some things here
(like IO-APIC accesses) that you definitely don't want in the cpu init code.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/