linux-kernel - Re: glitch1 results

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20070605192040.GA21148@elte.hu>
Date:	Tue, 5 Jun 2007 21:20:41 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Bill Davidsen <davidsen@....com>
Cc:	Linux Kernel M/L <linux-kernel@...r.kernel.org>
Subject: Re: glitch1 results - 2.6.21.3-cfs-v15


* Bill Davidsen <davidsen@....com> wrote:

> I have added cfs15 to the chart at 
> www.tmr.com/~davidsen/sched_smooth_05.html and updated the source of 
> the test at www.tmr.com/~public/source if anyone wants to run test on 
> their hardware.

thanks!

> I feel that on my hardware cfs-13 was the smoothest for this test and 
> for watching videos. Even relatively light load:
>   nice -10 make -j4 -s
> of a kernel would cause jumps on the video, gears or youtube.

ah, found this bug i think! Does the patch below fix it for you and does 
it bring back v13's smoothness for the reniced kernel build?

	Ingo

Index: linux/kernel/sched_fair.c
===================================================================
--- linux.orig/kernel/sched_fair.c
+++ linux/kernel/sched_fair.c
@@ -385,6 +374,7 @@ static void enqueue_sleeper(struct rq *r
 	 * during the whole sleep period:
 	 */
 	delta_fair = div64_s(delta_fair * load, load + p->load_weight);
+	delta_fair = div64_s(delta_fair * p->load_weight, NICE_0_LOAD);
 
 	prev_runtime = p->wait_runtime;
 	__add_wait_runtime(rq, p, delta_fair);
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/