linux-kernel - Re: [PATCH 17/22] 2.6.22-rc3 perfmon2 : modified powerpc files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20070605202730.GC11693@frankl.hpl.hp.com>
Date:	Tue, 5 Jun 2007 13:27:30 -0700
From:	Stephane Eranian <eranian@....hp.com>
To:	David Rientjes <rientjes@...gle.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 17/22] 2.6.22-rc3 perfmon2 : modified powerpc files

David,

On Tue, Jun 05, 2007 at 09:52:19AM -0700, David Rientjes wrote:
> > > > @@ -330,10 +330,22 @@
> > > >  #define __NR_signalfd		305
> > > >  #define __NR_timerfd		306
> > > >  #define __NR_eventfd		307
> > > > +#define __NR_pfm_create_context	308
> > > > +#define __NR_pfm_write_pmcs	(__NR_pfm_create_context+1)
> > > > +#define __NR_pfm_write_pmds	(__NR_pfm_create_context+2)
> > > > +#define __NR_pfm_read_pmds	(__NR_pfm_create_context+3)
> > > > +#define __NR_pfm_load_context	(__NR_pfm_create_context+4)
> > > > +#define __NR_pfm_start		(__NR_pfm_create_context+5)
> > > > +#define __NR_pfm_stop		(__NR_pfm_create_context+6)
> > > > +#define __NR_pfm_restart	(__NR_pfm_create_context+7)
> > > > +#define __NR_pfm_create_evtsets	(__NR_pfm_create_context+8)
> > > > +#define __NR_pfm_getinfo_evtsets (__NR_pfm_create_context+9)
> > > > +#define __NR_pfm_delete_evtsets (__NR_pfm_create_context+10)
> > > > +#define __NR_pfm_unload_context	(__NR_pfm_create_context+11)
> > > >  
> > > >  #ifdef __KERNEL__
> > > >  
> > > > -#define __NR_syscalls		308
> > > > +#define __NR_syscalls		319
> > > >  
> > > 
> > > The highest numbered syscall, __NR_pfm_create_context+11, is 319 and 
> > > __NR_syscalls is set to the same, which is wrong.
> > > 
> > You mean, it is off by one, right? Should be 320, then.
> > 
> 
> Yes, and the same off by one problem exists in your i386 patch that adds 
> the new syscalls as well.

Okay, I have fixed that now for powerpc, i386. Mips and IA-64 were fine.

Thanks.


-- 

-Stephane
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/