linux-kernel - Re: Linux 2.6.22-rc4 - sata_promise regression since -rc3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070605215256.GT31565@havoc.gtf.org>
Date:	Tue, 5 Jun 2007 17:52:56 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	Mikael Pettersson <mikpe@...uu.se>
Cc:	akpm@...ux-foundation.org, david@...eaves.com, htejun@...il.com,
	jean.luc.coulon@...il.com, jgarzik@...ox.com,
	michal.k.k.piotrowski@...il.com, torvalds@...ux-foundation.org,
	linux-kernel@...r.kernel.org
Subject: Re: Linux 2.6.22-rc4 - sata_promise regression since -rc3

On Tue, Jun 05, 2007 at 11:31:46PM +0200, Mikael Pettersson wrote:
> I can easily reproduce the problem in 2.6.22-rc4. There are no
> sata_promise changes between rc3 and rc4, but Tejun's libata
> polling SETXFER change was included in rc4. Reverting it makes
> sata_promise work again for me.

Ugh.


> I suspect that sata_promise.c:pdc_interrupt() should detect
> a qc w/ ATA_TFLAG_POLLING, treat the interrupt as spurious,
> and just call ata_chk_status(qc), similar to how sata_inic162x.c,
> sata_nv.c, sata_sil.c, and sata_vsc.c do things.

Yes, highly likely.

SFF-like controllers (and in this case, Promise is included in that
list) with their own interrupt handlers need their own polling handling
code.

	Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/