linux-kernel - Re: [Xen-devel] [patch 21/33] xen: Xen SMP guest support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 06 Jun 2007 01:33:18 -0700
From:	Jeremy Fitzhardinge <jeremy@...p.org>
To:	Jan Beulich <jbeulich@...ell.com>
CC:	Xen-devel <xen-devel@...ts.xensource.com>, Andi Kleen <ak@...e.de>,
	lkml <linux-kernel@...r.kernel.org>,
	Chris Wright <chrisw@...s-sol.org>,
	virtualization@...ts.osdl.org, Benjamin LaHaise <bcrl@...ck.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Ingo Molnar <mingo@...hat.com>
Subject: Re: [Xen-devel] [patch 21/33] xen: Xen SMP guest support

Jan Beulich wrote:
>> --- a/arch/i386/xen/time.c
>> +++ b/arch/i386/xen/time.c
>> @@ -105,17 +105,15 @@ static void get_runstate_snapshot(struct
>> 	preempt_enable();
>> }
>>
>> -static void setup_runstate_info(void)
>> +static void setup_runstate_info(int cpu)
>> {
>> 	struct vcpu_register_runstate_memory_area area;
>>
>> -	area.addr.v = &__get_cpu_var(runstate);
>> +	area.addr.v = &per_cpu(runstate, cpu);
>>
>> 	if (HYPERVISOR_vcpu_op(VCPUOP_register_runstate_memory_area,
>> 			       smp_processor_id(), &area))
>>     
>
> Shouldn't this be 'cpu' rather than 'smp_processor_id()'?
>   

Yes.  I'd noticed that, thought it got fixed later in the series, and
looks like I ultimately got confused.  Not sure when this crept in; it
has been correct in the past.

    J
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/