linux-kernel - Re: [PATCH TRIVIAL] icom whitespace cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 06 Jun 2007 09:16:11 -0500
From:	"V. Ananda Krishnan" <mansarov@...ux.vnet.ibm.com>
To:	linux-serial@...r.kernel.org
CC:	Chris Snook <csnook@...hat.com>, linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...l.org>
Subject: Re: [PATCH TRIVIAL] icom whitespace cleanups

Paul Mackerras wrote:
> Chris Snook writes:
> 
>> Clean up whitespace and comments in drivers/serial/icom.c
> 
> These changes seem totally unnecessary, as the existing indentation is
> according to a commonly-accepted style and is quite reasonable:
> 
I agree with Paul.

>> @@ -149,23 +149,23 @@ static void free_port_memory(struct icom
>>  	trace(icom_port, "RET_PORT_MEM", 0);
>>  	if (icom_port->recv_buf) {
>>  		pci_free_consistent(dev, 4096, icom_port->recv_buf,
>> -				    icom_port->recv_buf_pci);
>> +			icom_port->recv_buf_pci);
>>  		icom_port->recv_buf = NULL;
>>  	}
>>  	if (icom_port->xmit_buf) {
>>  		pci_free_consistent(dev, 4096, icom_port->xmit_buf,
>> -				    icom_port->xmit_buf_pci);
>> +			icom_port->xmit_buf_pci);
> 
> etc. etc.  The comment changes I agree on but not most of the other
> whitespace changes.
The comment changes are fine with me too.
> 
> Also you don't seem to have cc'd the driver author.
> 
Current contacts for the driver are: Ananda (mansarov@...ibm.com) and 
Wendy (wenxiong@...ibm.com)

:- Ananda

> Paul.
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
> 

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/