linux-kernel - Re: [PATCH 1/3] Char: stallion, don't fail with less than max panels

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 5 Jun 2007 17:17:45 -0700
From:	Andrew Morton <akpm@...gle.com>
To:	Jiri Slaby <jirislaby@...il.com>
Cc:	<linux-kernel@...r.kernel.org>, "Ingo Korb" <ingo@...na.de>
Subject: Re: [PATCH 1/3] Char: stallion, don't fail with less than max
 panels

On Tue,  5 Jun 2007 23:20:57 +0200 (CEST)
Jiri Slaby <jirislaby@...il.com> wrote:

> stallion, don't fail with less than max panels
>

Why not?

What problem is this patch fixing, and how does it fix it?

What are the consequences of not having this patch in the kernel?

etc.  More complete changlogs, please.

> 
> diff --git a/drivers/char/stallion.c b/drivers/char/stallion.c
> index e45113a..265abad 100644
> --- a/drivers/char/stallion.c
> +++ b/drivers/char/stallion.c
> @@ -2172,7 +2172,7 @@ static int __devinit stl_initech(struct stlbrd *brdp)
>  		}
>  		status = inb(ioaddr + ECH_PNLSTATUS);
>  		if ((status & ECH_PNLIDMASK) != nxtid)
> -			goto err_fr;
> +			break;
>  		panelp = kzalloc(sizeof(struct stlpanel), GFP_KERNEL);
>  		if (!panelp) {
>  			printk("STALLION: failed to allocate memory "
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/