linux-kernel - Re: [RFC] [Patch 1/4] statistics: no include hell for users

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <46675222.9000304@de.ibm.com>
Date:	Thu, 07 Jun 2007 02:32:34 +0200
From:	Martin Peschke <mp3@...ibm.com>
To:	Dave Hansen <hansendc@...ibm.com>
CC:	linux-kernel@...r.kernel.org, a.p.zijlstra@...llo.nl,
	jbaron@...hat.com, rostedt@...dmis.org, billh@...ppy.monkey.org,
	mingo@...e.hu, linux-s390@...r.kernel.org
Subject: Re: [RFC] [Patch 1/4] statistics: no include hell for users

Dave Hansen wrote:
> On Wed, 2007-06-06 at 23:33 +0200, Martin Peschke wrote:
>>  struct statistic_interface {
>>  /* private: */
>>         struct list_head         list;
>> -       struct dentry           *debugfs_dir;
>> -       struct dentry           *data_file;
>> -       struct dentry           *def_file;
>> +       void                    *debugfs_dir;
>> +       void                    *data_file;
>> +       void                    *def_file; 
> 
> If you don't actually dereference the pointer, you should just be able
> to declare:
> 
> 	struct dentry;
> 
> and be done with it, right?  You don't _need_ the includes to have just
> pointers.

Ah, looks like an established trick in kernel include files.
I guess I can revert the other, seq_file related change then as well.
Thank you. Will change my local copy.

Martin

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/