lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Thu, 07 Jun 2007 19:18:23 +0900
From:	Tejun Heo <htejun@...il.com>
To:	Peer Chen <peerchen@...il.com>
CC:	linux-kernel <linux-kernel@...r.kernel.org>,
	akpm <akpm@...ux-foundation.org>, jeff <jeff@...zik.org>
Subject: Re: [PATCH] ahci: Add MCP73/MCP77 support to AHCI driver

Hello,

This one looks much better.  Just few more things.

Peer Chen wrote:
> Add the MCP73/MCP77 support to ahci driver.
> The patch base on kernel 2.6.22-rc4
>  
> Signed-off-by: Peer Chen <peerchen@...il.com>
> ------------------------------------------------

The separator is '---'.  Automated tools are used, so sticking to it
makes things easier.

> --- linux-2.6.22-rc4/drivers/ata/ahci.c.orig
> +++ linux-2.6.22-rc4/drivers/ata/ahci.c
> @@ -426,6 +426,30 @@ static const struct pci_device_id ahci_p
>  	{ PCI_VDEVICE(NVIDIA, 0x0559), board_ahci },		/* MCP67 */
>  	{ PCI_VDEVICE(NVIDIA, 0x055a), board_ahci },		/* MCP67 */
>  	{ PCI_VDEVICE(NVIDIA, 0x055b), board_ahci },		/* MCP67 */
> +	{ PCI_VDEVICE(NVIDIA, 0x07f0), board_ahci },		/* MCP73 */
> +	{ PCI_VDEVICE(NVIDIA, 0x07f1), board_ahci },		/* MCP73 */
[--snip--]

Whoa, that's a lot of PCI IDs.  AHCI PCI class code doesn't catch them?

-- 
tejun
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ