linux-kernel - Re: drivers/media/dvb/b2c2/flexcop-dma.c uses PCI DMA API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1181220656.4187.64.camel@gaivota>
Date:	Thu, 07 Jun 2007 09:50:56 -0300
From:	Mauro Carvalho Chehab <mchehab@...radead.org>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:	v4l-dvb-maintainer@...uxtv.org, linux-dvb@...uxtv.org,
	Linux Kernel Development <linux-kernel@...r.kernel.org>
Subject: Re: drivers/media/dvb/b2c2/flexcop-dma.c uses PCI DMA API

Hi Geert,

Em Qua, 2007-06-06 às 21:11 +0200, Geert Uytterhoeven escreveu:
> 	Hi,
> 
> drivers/media/dvb/b2c2/flexcop-dma.c uses the PCI DMA API, but DVB_B2C2_FLEXCOP
> doesn't depend on PCI, causing the following problem on PCI-less systems:
> 
> | linux/drivers/media/dvb/b2c2/flexcop-dma.c:20: warning: implicit declaration of function 'pci_alloc_consistent'
> | linux/drivers/media/dvb/b2c2/flexcop-dma.c:20: warning: implicit declaration of function 'pci_alloc_consistent'
> 
> Apparently this is the flexcop DMA core, which is used by both
> DVB_B2C2_FLEXCOP_PCI and DVB_B2C2_FLEXCOP_USB.
> 
> DVB_B2C2_FLEXCOP_PCI depends on PCI.
> DVB_B2C2_FLEXCOP_USB depends on USB.

Thanks for pointing us about this issue. While the usage of the generic
dma is the better way, a simple fix can be applied by simply moving
flexcop-dma to b2c2-flexcop-pci (currently, only the last uses the DMA
stuff). I've committed such patch. It is available at:

http://linuxtv.org/hg/v4l-dvb/rev/c314ec17335a

 
Cheers,
Mauro

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/