linux-kernel - Re: 2.6.22-rc4-mm1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 07 Jun 2007 17:04:20 +0200
From:	Kay Sievers <kay.sievers@...y.org>
To:	Michal Piotrowski <michal.k.k.piotrowski@...il.com>,
	Peter Jones <pjones@...hat.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, Greg Kroah-Hartman <gregkh@...e.de>
Subject: Re: 2.6.22-rc4-mm1

On Thu, 2007-06-07 at 11:41 +0200, Michal Piotrowski wrote:
> Kay Sievers pisze:
> > On Thu, 2007-06-07 at 10:40 +0200, Michal Piotrowski wrote:
> >> Kay Sievers pisze:
> >>> On Wed, 2007-06-06 at 20:48 +0200, Michal Piotrowski wrote:
> >>>> Andrew Morton pisze:
> >>>>> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.22-rc4/2.6.22-rc4-mm1/
> >>>>>
> >>>> Kay, your patch gregkh-driver-block-device.patch breaks Fedora 7 initrd
> >>>> http://www.stardust.webpages.pl/files/tbf/bitis-gabonica/2.6.22-rc4-mm1/initrd.jpg
> >>>>
> >>>> Please fix it ASAP, I can't test kernel...
> >>> Do you have CONFIG_SYSFS_DEPRECATED set or unset?
> >>>
> >>> Kay
> >>>
> >>>
> >> cat ../linux-mm-bo/.config | grep CONFIG_SYSFS_DEPRECATED
> >> # CONFIG_SYSFS_DEPRECATED is not set
> > 
> > Oh, could you possibly try (with the block patch included) setting it to
> > yes and see if it works? That would help to find what's going wrong.
> 
> I enabled CONFIG_SYSFS_DEPRECATED and 2.6.22-rc4-mm2 boots fine.

Michal, thanks a lot for the testing.

Peter, looking at your mkinitrd code, it works only with
CONFIG_SYSFS_DEPRECATED enabled when block devices are converted to
class devices.
Any chance to replace lstat() with stat() while looking for devices in
sysfs? Remember, _anything_ in sysfs can be symlink or a directory, you
can't assume one or the other. When things change internally in the
kernel, we can often provide symlinks for backwards compatibility, but
lstat() obviously can't works here.

Thanks,
Kay

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/