linux-kernel - Re: [REPOST PATCH] sata_promise: use TF interface for polling NODATA commands

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070607151717.GA6653@havoc.gtf.org>
Date:	Thu, 7 Jun 2007 11:17:17 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	Tejun Heo <htejun@...il.com>
Cc:	Mikael Pettersson <mikpe@...uu.se>, akpm@...ux-foundation.org,
	david@...eaves.com, jean.luc.coulon@...il.com, jgarzik@...ox.com,
	michal.k.k.piotrowski@...il.com, torvalds@...ux-foundation.org,
	linux-kernel@...r.kernel.org
Subject: Re: [REPOST PATCH] sata_promise: use TF interface for polling NODATA commands

On Wed, Jun 06, 2007 at 07:21:22PM +0900, Tejun Heo wrote:
> sata_promise uses two different command modes - packet and TF.  Packet
> mode is intelligent low-overhead mode while TF is the same old
> taskfile interface.  As with other advanced interface (ahci/sil24),
> ATA_TFLAG_POLLING has no effect in packet mode.  However, PIO commands
> are issued using TF interface in polling mode, so pdc_interrupt()
> considers interrupts spurious if ATA_TFLAG_POLLING is set.
> 
> This is broken for polling NODATA commands because command is issued
> using packet mode but the interrupt handler ignores it due to
> ATA_TFLAG_POLLING.  Fix pdc_qc_issue_prot() such that ATA/ATAPI NODATA
> commands are issued using TF interface if ATA_TFLAG_POLLING is set.
> 
> This patch fixes detection failure introduced by polling SETXFERMODE.
> 
> Signed-off-by: Tejun Heo <htejun@...il.com>
> ---
> David, please verify this patch.  Mikael, does this look okay?  Please
> push this upstream after David and Mikael's ack.
> 
> (This repost is identical to the previous posting but it's now on the
>  correct thread.)

Acked-by: Jeff Garzik <jeff@...zik.org>

Tejun, would you mind pushing this upstream to Linus/Andrew?

I'm travelling this week, and my home firewall doesn't like me.
It is probably easier for you than me.

	Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/