linux-kernel - Re: [i2c] i2c module aliases

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070607175342.3006e872@hyperion.delvare>
Date:	Thu, 7 Jun 2007 17:53:42 +0200
From:	Jean Delvare <khali@...ux-fr.org>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:	i2c@...sensors.org,
	Linux Kernel Development <linux-kernel@...r.kernel.org>,
	Greg KH <greg@...ah.com>, David Brownell <david-b@...bell.net>
Subject: Re: [i2c] i2c module aliases

Hi Geert,

On Wed, 6 Jun 2007 23:32:38 +0200 (CEST), Geert Uytterhoeven wrote:
> >From browsing through file2alias.c, I have the impression there's a
> missing TO_NATIVE() conversion in the handling of 16-bit (hence,
> endian-affected) i2c IDs.
> This will cause the module aliases to be incorrect when cross-compiling
> for a system with a different endianness.  Is that correct?
> If yes, the patch below adds the missing conversion.
> 
> Of course, no driver seems to use `MODULE_DEVICE_TABLE(i2c, ...)' yet,
> hence nobody noticed.
> 
> Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> 
> --- a/scripts/mod/file2alias.c
> +++ b/scripts/mod/file2alias.c
> @@ -390,6 +390,7 @@ static int do_vio_entry(const char *file
>  
>  static int do_i2c_entry(const char *filename, struct i2c_device_id *i2c, char *alias)
>  {
> +	i2c->id = TO_NATIVE(i2c->id);
>  	strcpy(alias, "i2c:");
>  	ADD(alias, "id", 1, i2c->id);
>  	return 1;
> 

Looks correct. However I am curious what this "i2c->id" is supposed to
represent, given that I2C devices do not have any form of ID as PCI or
USB devices have. No driver uses "MODULE_DEVICE_TABLE(i2c, ...)"
probably just because it doesn't make sense. So, rather than fixing
this, shouldn't we simply wipe out struct i2c_device_id? Greg, David?

-- 
Jean Delvare
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/