linux-kernel - Re: [PATCH 20/22] 2.6.22-rc3 perfmon2 : new x86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20070607215503.GC29058@erda.amd.com>
Date:	Thu, 7 Jun 2007 23:55:03 +0200
From:	"Robert Richter" <robert.richter@....com>
To:	"Stephane Eranian" <eranian@....hp.com>
cc:	"Andi Kleen" <andi@...stfloor.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 20/22] 2.6.22-rc3 perfmon2 : new x86_64 files

Stephane,

> > > +
> > > +	if (current_cpu_data.x86 != 15) {
> > > +		PFM_INFO("unsupported family=%d", current_cpu_data.x86);
> > > +		return -1;
> > > +	}
> > 
> > Already obsolete with Barcelona and Griffin (16 and 17) but very similar
> > counters. 
> > 
> Yes, but those will get new description modules.

see enclosed patch that also enables Barcelona cores. I have tested
your releases on K8 and Barcelona. 2.6.21 release
(perfmon-new-base-070509) works fine. In 2.6.22-rc3 syscalls seems to
be broken. I receive a EBADF error when trying to create a context. It
seems that sys_pfm_create_context() is never called. I could not yet
dig into this deeper.

There are also patches available for new family 10 features. I will
release these patches next week. I already implemented a generic AMD64
PMU description that detects features for different families and CPU
revisions. Enclosed patch is part of the patch series.

-Robert



Index: linux-2.6.22-rc3/arch/i386/perfmon/perfmon.c
===================================================================
--- linux-2.6.22-rc3.orig/arch/i386/perfmon/perfmon.c
+++ linux-2.6.22-rc3/arch/i386/perfmon/perfmon.c
@@ -1059,6 +1059,7 @@ char *pfm_arch_get_pmu_module_name(void)
 			goto try_arch;
 		}
 	case 15:
+	case 16:
 		/* All Opteron processors */
 		if (cpu_data->x86_vendor == X86_VENDOR_AMD)
 			return "perfmon_k8";
Index: linux-2.6.22-rc3/arch/x86_64/perfmon/perfmon_k8.c
===================================================================
--- linux-2.6.22-rc3.orig/arch/x86_64/perfmon/perfmon_k8.c
+++ linux-2.6.22-rc3/arch/x86_64/perfmon/perfmon_k8.c
@@ -307,7 +307,12 @@ static int pfm_k8_probe_pmu(void)
 		return -1;
 	}
 
-	if (current_cpu_data.x86 != 15) {
+	switch (current_cpu_data.x86) {
+	case 15:
+	case 16:
+		PFM_INFO("found family=%d", current_cpu_data.x86);
+		break;
+	default:
 		PFM_INFO("unsupported family=%d", current_cpu_data.x86);
 		return -1;
 	}

-- 
AMD Saxony, Dresden, Germany
Operating System Research Center
email: robert.richter@....com



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/