linux-kernel - Re: [PATCH -mm] Add LZO1X compression support to the kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 7 Jun 2007 15:06:18 +0900
From:	Paul Mundt <lethal@...ux-sh.org>
To:	Richard Purdie <rpurdie@...nedhand.com>
Cc:	akpm <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Nitin Gupta <nitingupta910@...il.com>
Subject: Re: [PATCH -mm] Add LZO1X compression support to the kernel

On Wed, Jun 06, 2007 at 06:26:32PM +0100, Richard Purdie wrote:
> +/* Which machines to allow unaligned accesses on */
> +#if defined(CONFIG_X86_32) || defined(CONFIG_X86_64)
> +#define LZO_UNALIGNED_OK_2
> +#define LZO_UNALIGNED_OK_4
> +#endif
> +
This is silly, just use get/put_unaligned(). This same issue was pointed
out in Nitin's patch and already corrected there, perhaps it would be
more constructive to work on getting cleanups from both implementations
integrated in to something mergeable rather than trying to see who can
get in to -mm first.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/