linux-kernel - Re: [RFC] [Patch 4/4] lock contention tracking slimmed down

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <46674FA6.8060904@de.ibm.com>
Date:	Thu, 07 Jun 2007 02:21:58 +0200
From:	Martin Peschke <mp3@...ibm.com>
To:	Ingo Molnar <mingo@...e.hu>
CC:	linux-kernel@...r.kernel.org, a.p.zijlstra@...llo.nl,
	jbaron@...hat.com, rostedt@...dmis.org, linux-s390@...r.kernel.org
Subject: Re: [RFC] [Patch 4/4] lock contention tracking slimmed down

Ingo Molnar wrote:
> * Martin Peschke <mp3@...ibm.com> wrote:
> 
>> - lock_time_inc() vs. statistic_add_util()
> 
> please fix the coding style in lib/statistic.c. It's full of:
> 
> {
>         unsigned long long i;
>         if (value <= stat->u.histogram.range_min)
>                 return 0;
> 
> put a newline after variable sections.
> 
> and:
> 
>         on_each_cpu(_statistic_barrier, NULL, 0, 1);
>         return 0;
> 
> preferably use a newline before 'return' statements as well. (this is 
> not always necessary, but in the above case it looks better)

Will do (in my local tree, for the time being).

Good points. Thnaks for reviewing.


	Martin

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/