linux-kernel - Re: [patch 4/4] FUTEX: Tidy up the code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070608071045.GA30226@elte.hu>
Date:	Fri, 8 Jun 2007 09:10:45 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Thomas Gleixner <tglx@...utronix.de>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Steven Rostedt <rostedt@...dmis.org>,
	Eric Dumazet <dada1@...mosbay.com>
Subject: Re: [patch 4/4] FUTEX: Tidy up the code


* Thomas Gleixner <tglx@...utronix.de> wrote:

> The recent PRIVATE and REQUEUE_PI changes to the futex code made it hard to read.
> Tidy it up.
> 
> Signed-off-by: Thomas Gleixner <tglx@...utronix.de>

looks good to me:

  Acked-by: Ingo Molnar <mingo@...e.hu>

> -		if (!pi) {
> -			if (uval & FUTEX_WAITERS)
> +		if (!pi && (uval & FUTEX_WAITERS))
>  				futex_wake(uaddr, &curr->mm->mmap_sem, 1);
> -		}

one too much tab left in the futex_wake line i guess?

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/