linux-kernel - Re: [PATCH 1/1] Watchdog driver for AT32AP700X devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1181301608.28296.44.camel@localhost.localdomain>
Date:	Fri, 08 Jun 2007 13:20:08 +0200
From:	Hans-Christian Egtvedt <hcegtvedt@...el.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	linux-kernel@...r.kernel.org,
	Haavard Skinnemoen <hskinnemoen@...el.com>,
	Wim Van Sebroeck <wim@...ana.be>
Subject: Re: [PATCH 1/1] Watchdog driver for AT32AP700X devices

On Fri, 2007-06-08 at 09:23 +0200, Hans-Christian Egtvedt wrote:
> On Thu, 2007-06-07 at 16:09 -0700, Andrew Morton wrote:
> > On Wed,  6 Jun 2007 16:04:07 +0200
> > Hans-Christian Egtvedt <hcegtvedt@...el.com> wrote:
> > 
> > > This patch adds support for the built in watchdog in AT32AP700X devices.
> > > 
> > > Tested on AT32AP7000 and ATSTK1000.
> > > 
> > > Hardware documentation can be found in the AT32AP7000 datasheet.
> > > 
> > > ...
> > >
> > > +static int __init at32_wdt_probe(struct platform_device *pdev)
> > > +{
> 
> <cut start of _probe>
> 
> > > +	wdt->regs = ioremap(regs->start, regs->end - regs->start + 1);
> > 
> > I see an ioremap(), but there are no iounmap()s anywhere.
> 
> Hmm, that would be my fault, please see the attach patch, it should
> apply clean to -mm after your two -fix{1,2} patches.

I missed iounmap if the probe function fails, the included patch
corrects this. Applies after the previous patches.

Do you want me to fold all five patches? original + fix1 and fix2 +
iounmap patches.

Sorry for the minor fixes.

-- 
With kind regards,

Hans-Christian Egtvedt, siv.ing. (M.Sc.)
Applications Engineer - AVR32 System Solutions - Atmel Norway

Download attachment "0001-at32ap700x-wdt-add-iounmap-if-probe-function-fails.txt" of type "application/mbox" (1476 bytes)