linux-kernel - Re: [patch/rfc] implement memmem() locally in kallsyms.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <46694B39.6070304@grupopie.com>
Date:	Fri, 08 Jun 2007 13:27:37 +0100
From:	Paulo Marques <pmarques@...popie.com>
To:	Mike Frysinger <vapier@...too.org>
CC:	linux-kernel@...r.kernel.org
Subject: Re: [patch/rfc] implement memmem() locally in kallsyms.c

Mike Frysinger wrote:
> This patch basically copies the gnulib version of memmem() into
> scripts/kallsyms.c.  While a useful function, it isn't in POSIX so some
> systems (like Darwin) choose to omit it.  How do others feel ?

Well, the only use of memmem in scripts/kallsyms.c is to find tokens of 
size 2, so we can use a simplified version instead (and probably get 
better code in the process).

How about the attached patch instead?

If you approve it, I'll post it appropriately for inclusion in -mm.

-- 
Paulo Marques - www.grupopie.com

"God is real, unless declared integer."

View attachment "patch" of type "text/plain" (1083 bytes)