[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Pine.LNX.4.64.0706081131150.30811@localhost.localdomain>
Date: Fri, 8 Jun 2007 11:34:01 -0400 (EDT)
From: "Robert P. J. Day" <rpjday@...dspring.com>
To: Jan Engelhardt <jengelh@...putergmbh.de>
cc: Alan Cox <alan@...rguk.ukuu.org.uk>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
Andrew Morton <akpm@...l.org>
Subject: Re: [PATCH] Include <asm/termbits.h> from <linux/tty_driver.h>.
On Fri, 8 Jun 2007, Jan Engelhardt wrote:
>
> On Jun 8 2007 16:30, Alan Cox wrote:
> >
> >>
> >> The header file <linux/tty_driver.h> should include <asm/termbits.h>
> >> to pick up the definition of "struct ktermios"; otherwise, you run the
> >> risk of seeing:
> >
> >Risk - which compile combinations does it actually show up with and
> >is it not better to fix the C file in question not grow the
> >horribly tangled include deps further
>
> struct ktermios; /* that's it */
um ... what does that mean? consider this snippet from
<linux/tty_driver.h>:
struct tty_driver {
...
struct ktermios init_termios; /* Initial termios */
...
doesn't this suggest that you better have a definition of that
ktermios struct before this point?
rday
--
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA
http://fsdev.net/wiki/index.php?title=Main_Page
========================================================================
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists