linux-kernel - Re: [PATCH] Include <asm/termbits.h> from <linux/tty

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 8 Jun 2007 11:42:10 -0400 (EDT)
From:	"Robert P. J. Day" <rpjday@...dspring.com>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
cc:	Jan Engelhardt <jengelh@...putergmbh.de>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...l.org>
Subject: Re: [PATCH] Include <asm/termbits.h> from <linux/tty_driver.h>.

On Fri, 8 Jun 2007, Alan Cox wrote:

> > > >Risk - which compile combinations does it actually show up with and
> > > >is it not better to fix the C file in question not grow the
> > > >horribly tangled include deps further
> > >
> > > struct ktermios; /* that's it */
> >
> > um ... what does that mean?  consider this snippet from
> > <linux/tty_driver.h>:
>
> Which compile combination shows the sequence you are reporting ?

sorry, i don't understand the question.  i'm just running "make" on a
simple module i wrote, using the prototypical in-directory makefile to
build out-of-tree.

the first four lines of my module source file are:

#include <linux/module.h>
#include <linux/init.h>
#include <asm/termbits.h>               /* Shouldn't be necessary */
#include <linux/tty_driver.h>           /* For struct tty_driver */

  if i omit the inclusion of the termbits.h header, i get the
aforementioned error.  beyond that, i'm unclear on what you're asking.

rday
-- 
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA

http://fsdev.net/wiki/index.php?title=Main_Page
========================================================================
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/