[<prev] [next>] [day] [month] [year] [list]
Message-ID: <46697b4e.61N/B7QsAQbBzAlt%dougthompson@xmission.com>
Date: Fri, 08 Jun 2007 09:52:46 -0600
From: dougthompson@...ssion.com
To: alan@...rguk.ukuu.org.uk, linux-kernel@...r.kernel.org,
akpm@...l.org
Subject: [PATCH 3/6]
From: Douglas Thompson <dougthompson@...ssion.com>
Compiling this module gave a warning that the return
value of 'pci_bus_add_device()' was not checked.
This patch adds that check and an output message
Signed-off-by: Douglas Thompson <dougthompson@...ssion.com>
Cc: alan@...rguk.ukuu.org.uk
---
Index: linux-2.6.22-rc4-mm1/drivers/edac/i82875p_edac.c
===================================================================
--- linux-2.6.22-rc4-mm1.orig/drivers/edac/i82875p_edac.c
+++ linux-2.6.22-rc4-mm1/drivers/edac/i82875p_edac.c
@@ -270,6 +270,7 @@ static int i82875p_setup_overfl_dev(stru
{
struct pci_dev *dev;
void __iomem *window;
+ int err;
*ovrfl_pdev = NULL;
*ovrfl_window = NULL;
@@ -287,7 +288,12 @@ static int i82875p_setup_overfl_dev(stru
if (dev == NULL)
return 1;
- pci_bus_add_device(dev);
+ err = pci_bus_add_device(dev);
+ if (err) {
+ i82875p_printk(KERN_ERR,
+ "%s(): pci_bus_add_device() Failed\n",
+ __func__);
+ }
}
*ovrfl_pdev = dev;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists