[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20070608183232.GA12967@kroah.com>
Date: Fri, 8 Jun 2007 11:32:32 -0700
From: Greg KH <greg@...ah.com>
To: "Robert P. J. Day" <rpjday@...dspring.com>,
Pete Zaitcev <zaitcev@...hat.com>
Cc: Chuck Ebbert <cebbert@...hat.com>,
USB development list <linux-usb-devel@...ts.sourceforge.net>,
linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: blank filenames in /sys/modules, kernel 2.6.21
On Fri, Jun 08, 2007 at 02:05:22PM -0400, Robert P. J. Day wrote:
> On Fri, 8 Jun 2007, Chuck Ebbert wrote:
>
> > We just found a file with this name in 2.6.21:
> >
> > Directory name: /sys/module/nousb/parameters
> > File name: ""
> >
> > IOW the file has an empty name. Is this intentional?
> > It sure confuses updatedb...
> >
> > https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=242715
>
> that appears to be the result of:
>
> $ grep -r __module_param_call *
> drivers/usb/core/usb.c:__module_param_call("", nousb, param_set_bool, param_get_bool, &nousb, 0444);
> include/linux/moduleparam.h:#define __module_param_call(prefix, name, set, get, arg, perm) \
> include/linux/moduleparam.h: __module_param_call(MODULE_PARAM_PREFIX, name, set, get, arg, perm)
>
> and from drivers/usb/core/usb.c:
>
> /* format to disable USB on kernel command line is: nousb */
> __module_param_call("", nousb, param_set_bool, param_get_bool, &nousb, 0444);
>
> one has to wonder about the value of a macro that is invoked only
> once throughout the entire tree.
Pete added that back in December of 2005 (git-blame rocks...). So what
has changed recently to cause this to do different things in sysfs?
Robert, what do you suggest we change this usage to look like?
thanks,
greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists