linux-kernel - Re: [patch 7/8] fdmap v2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0706091006320.14037@alien.or.mcafeemobile.com>
Date:	Sat, 9 Jun 2007 10:08:04 -0700 (PDT)
From:	Davide Libenzi <davidel@...ilserver.org>
To:	Al Viro <viro@....linux.org.uk>
cc:	Ulrich Drepper <drepper@...hat.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Alan Cox <alan@...rguk.ukuu.org.uk>,
	Theodore Tso <tytso@....edu>,
	Eric Dumazet <dada1@...mosbay.com>,
	Kyle Moffett <mrmacman_g4@....com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Ingo Molnar <mingo@...e.hu>
Subject: Re: [patch 7/8] fdmap v2 - implement sys_socket2

On Sat, 9 Jun 2007, Davide Libenzi wrote:

> On Sat, 9 Jun 2007, Al Viro wrote:
> 
> > That's simply not true.  On the current kernel nothing stops you from e.g.
> > picking a random number and using F_DUPFD.  Voila - there's your randomized
> > descriptor.  Portable to earlier kernels.
> > 
> > Moreover, nonsense^H^H^Hq_fd() can be implemented in userland just fine
> > if we allow F_DUPFD to arbitrary number - just pass it a random one *or*
> > base chosen like davedel is doing (constant + 20bit random chosen at start
> > time).
> 
> That does not work. Or better, it works but it forces *huge* fdtables to 
> be created. To do that, you need "start" to be over NR_FILE, and this 
> creates an fdtable bigger than NR_FILE ((pointer-size + a-few-bits) * 
> NR_FILE) propagated down to every app you fork.

Keep in mind also, that quite a few places in the code, walk through the 
whole fdtable memory. So it is not only a problem of wasted RAM.


- Davide


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/