lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 9 Jun 2007 21:26:59 +0200 From: "Julio M. Merino Vidal" <jmerino@...upc.edu> To: Christian Kujau <lists@...dbynature.de> Cc: linux-kernel@...r.kernel.org Subject: Re: [PATCH] Remove bashisms from scripts/extract-ikconfig On 09/06/2007, at 21:22, Christian Kujau wrote: > Hi, > > I noticed that scripts/extract-ikconfig is using /bin/sh in its > shebang but when /bin/sh is not a symlink to bash, it breaks with: > [...] > @@ -18,8 +18,8 @@ function dump_config { > fi > end=`$binoffset $file $IKCFG_ED 2>/dev/null` > > - let start="$start + 8" > - let size="$end - $start" > + start="`expr $start + 8`" > + size="`expr $end - $start`" Wouldn't this be better expressed as: start=$(($start + 8)) size=$(($end - $start)) to avoid invoking a subshell? -- Julio M. Merino Vidal <jmerino@...upc.edu> - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists