linux-kernel - Re: [PATCH 0/7] Cleanup code to replace DPRINTK with pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 09 Jun 2007 14:43:26 +0800
From:	Ian Kent <raven@...maw.net>
To:	Jack Stone <jack@...keye.stone.uk.eu.org>
Cc:	linux-kernel@...r.kernel.org, hpa@...or.com
Subject: Re: [PATCH 0/7] Cleanup code to replace DPRINTK with pr_debug

On Fri, 2007-06-08 at 23:18 +0100, Jack Stone wrote:
> This patch series replaces DPRINTK with pr_debug in alternative.c,
> autofs, autofs4
> and ncpfs. A new function called pr_err is also added to keep
> functionality in
> ncpfs. The last 2 patches add support for pr_debug_pid and apply it to
> autofs4 to
> keep the output the same as the current DPRINTK statements.

And ???

Presenting patches without the reason why they are needed is not a good
policy.

Not to mention that several appear to be missing headers, I can't
believe you tested that they applied before posting them.

NACK.

Ian


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/