linux-kernel - Re: [PATCH 1/2] [RFC] PCI: read revision ID by default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20070609.010249.77260306.davem@davemloft.net>
Date:	Sat, 09 Jun 2007 01:02:49 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	grundler@...isc-linux.org
Cc:	auke-jan.h.kok@...el.com, linux-kernel@...r.kernel.org,
	linux-pci@...ey.karlin.mff.cuni.cz, gregkh@...e.de
Subject: Re: [PATCH 1/2] [RFC] PCI: read revision ID by default

From: Grant Grundler <grundler@...isc-linux.org>
Date: Sat, 9 Jun 2007 00:59:53 -0600

> On Fri, Jun 08, 2007 at 03:46:30PM -0700, Auke Kok wrote:
> > Currently there are 97 occurrences where drivers need the pci
> > revision ID. We can do this once for all devices. Even the pci
> > subsystem needs the revision several times for quirks. The extra
> > u8 member pads out nicely in the pci_dev struct.
> 
> Good idea. I always wondered why we read the invariants so often
> in the code.

BTW, if you add code like this, you also have to add the
appropriate code to do this for all the platforms that probe
the PCI bus using a firmware device tree like sparc64
and powerpc do.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/