linux-kernel - Re: [PATCH] drivers/isdn/hisax: ARRAY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070610131402.GR2649@lug-owl.de>
Date:	Sun, 10 Jun 2007 15:14:02 +0200
From:	Jan-Benedict Glaw <jbglaw@...-owl.de>
To:	Andi Drebes <lists-receive@...grammierforen.de>,
	kernel-janitors@...ts.osdl.org,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drivers/isdn/hisax: ARRAY_SIZE instead of sizeof

On Sun, 2007-06-10 15:11:22 +0200, Karsten Keil <kkeil@...e.de> wrote:
> > --- a/drivers/isdn/hisax/callc.c
> > +++ b/drivers/isdn/hisax/callc.c
> > @@ -834,7 +834,7 @@ static struct FsmNode fnlist[] __initdata =
> >  };
> >  /* *INDENT-ON* */
> >  
> > -#define FNCOUNT (sizeof(fnlist)/sizeof(struct FsmNode))
> > +#define FNCOUNT ARRAY_SIZE(fnlist)
> >  
> >  int __init
> >  CallcNew(void)
>
> This is OK, thanks for changing.

I'd suggest to not use another define, but use ARRAY_SIZE(foo)
_instead of_ eg. FNCOUNT.

MfG, JBG

-- 
      Jan-Benedict Glaw      jbglaw@...-owl.de              +49-172-7608481
Signature of:           Ich hatte in letzter Zeit ein bißchen viel Realitycheck.
the second  :               Langsam möchte ich mal wieder weiterträumen können.
                             -- Maximilian Wilhelm (18. Mai 2006, #lug-owl.de)

Download attachment "signature.asc" of type "application/pgp-signature" (190 bytes)