linux-kernel - Re: [PATCH 2/2] [RFC] PCI: Change all drivers to use pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20070611151944.GH9174@redhat.com>
Date:	Mon, 11 Jun 2007 11:19:44 -0400
From:	Dave Jones <davej@...hat.com>
To:	Auke Kok <auke-jan.h.kok@...el.com>
Cc:	linux-kernel@...r.kernel.org, linux-pci@...ey.karlin.mff.cuni.cz,
	gregkh@...e.de
Subject: Re: [PATCH 2/2] [RFC] PCI: Change all drivers to use
	pci_device->revision

On Fri, Jun 08, 2007 at 03:46:36PM -0700, Auke Kok wrote:
 > Instead of all drivers reading pci config space to get the revision
 > ID, they can now use the pci_device->revision member.
 > 
 > This exposes some issues where drivers where reading a word or a dword
 > for the revision number, and adding useless error-handling around the
 > read. Some drivers even just read it for no purpose of all.
 > 
 > In devices where the revision ID is being copied over and used in what
 > appears to be the equivalent of hotpath, I have left the copy code
 > and the cached copy as not to influence the driver's performance.
 > 
 > Compile tested with make all{yes,mod}config on x86_64 and i386.
 > 
 > Signed-off-by: Auke Kok <auke-jan.h.kok@...el.com>

ACKed-by: Dave Jones <davej@...hat.com>
for the cpufreq bits.

	Dave

-- 
http://www.codemonkey.org.uk
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/