[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20070611233917.4bd8c6d7@the-village.bc.nu>
Date: Mon, 11 Jun 2007 23:39:17 +0100
From: Alan Cox <alan@...rguk.ukuu.org.uk>
To: Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Cc: jeff@...zik.org
Subject: Re: libata passthru: support PIO multi commands
> + if (is_multi_taskfile(tf)) {
> + unsigned int multi_count = 1 << (cdb[1] >> 5);
> +
> + /* compare the passed through multi_count
> + * with the cached multi_count of libata
> + */
> + if (multi_count != dev->multi_count)
> + ata_dev_printk(dev, KERN_WARNING,
> + "invalid multi_count %u ignored\n",
> + multi_count);
> + }
What limits log spamming here ? Also shouldn't we error this
situation not proceed and hope that enough data was supplied not
to leave us stuck half way through a command having made a nasty
mess on disk ?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists