linux-kernel - Re: libata passthru: support PIO multi commands

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070612170519.5f427a70@the-village.bc.nu>
Date:	Tue, 12 Jun 2007 17:05:19 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Jeff Garzik <jeff@...zik.org>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	IDE/ATA development list <linux-ide@...r.kernel.org>,
	Albert Lee <albertcc@...ibm.com>
Subject: Re: libata passthru: support PIO multi commands

> ata_scsi_pass_thru() is not executed at ioctl submission time (block 
> queue submission time), but rather immediately before it is issued to 
> the drive.  At that point you know the bus is idle, all other commands 
> have finished executing, and dev->multi_count is fresh not stale.  The 
> code path goes from ata_scsi_pass_thru() to ata_qc_issue() without 
> releasing the spinlock, even.

Think up to user space

Poorusersapp			set multicount to 4

Evilproprietarytuningdaemon	set multicount to 8

Poorusersapp			issue I/O

at which point an error is indeed best.

> But the last point is true -- we should error rather than just warn 
> there, AFAICS.

Definitely. We've been asked "please do something stupid" and not even in
a case where the requester may know better.

Alan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/