[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20070612094615.9e5557e5.akpm@linux-foundation.org>
Date: Tue, 12 Jun 2007 09:46:15 -0700
From: Andrew Morton <akpm@...ux-foundation.org>
To: Jens Axboe <jens.axboe@...cle.com>
Cc: Peter Zijlstra <peterz@...radead.org>, linux-kernel@...r.kernel.org
Subject: Re: splice: move balance_dirty_pages_ratelimited() outside of
splice actor
On Tue, 12 Jun 2007 14:44:50 +0200 Jens Axboe <jens.axboe@...cle.com> wrote:
> splice
btw, I'm staring in profound mystification at this:
int generic_pipe_buf_steal(struct pipe_inode_info *pipe,
struct pipe_buffer *buf)
{
struct page *page = buf->page;
if (page_count(page) == 1) {
lock_page(page);
return 0;
}
return 1;
}
afacit that `if page_count(page)' test could be replaced by
`if today_is_tuesday()'. But then I don't have the foggiest idea
what it's trying to do.
It would be nice to get some comments in and around here.
Also, I was trying to work out the role and responsibility of the ->pin
callback, and gave up.
There isn't a lot of point in explaining this over email - one should be
able to gain an understanding of these things by reading the code. I think
the best way of tackling this would be to comprehensively document
pipe_buf_operations and pipe_inode_info, please...
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists