linux-kernel - Re: 2.6.22-rc3 hibernate(?) fails totally

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.0.98.0706121123550.14121@woody.linux-foundation.org>
Date:	Tue, 12 Jun 2007 11:43:37 -0700 (PDT)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	David Greaves <david@...eaves.com>
cc:	David Chinner <dgc@....com>, Tejun Heo <htejun@...il.com>,
	"Rafael J. Wysocki" <rjw@...k.pl>, xfs@....sgi.com,
	"'linux-kernel@...r.kernel.org'" <linux-kernel@...r.kernel.org>,
	linux-pm <linux-pm@...ts.osdl.org>, Neil Brown <neilb@...e.de>,
	Jeff Garzik <jgarzik@...ox.com>
Subject: Re: 2.6.22-rc3 hibernate(?) fails totally - regression (xfs on
 raid6)

On Fri, 8 Jun 2007, David Greaves wrote:
> 
> positive: I can now get sysrq-t :)

Ok, so color me confused, and maybe I have missed some of the emails or 
skimmed over them too fast (there's been too many of them ;), but

 - I haven't actually seen any traces for this (netconsole apparently 
   doesn't work for you, and I'm not surprised: it never really worked 
   well for me over suspend/resume either, but I think I saw a mention of 
   serial console?)

 - You apparently bisected it down to the range

	0a3fd051c7036ef71b58863f8e5da7c3dabd9d3f <- works
	1d30c33d8d07868199560b24f10ed6280e78a89c <- breaks

   but some of the intermediates in that range didn't compile. Correct?

Can you try to bisect down a bit more, despite the compile error? Just do

	git bisect start
	git bisect good 0a3fd051c7036ef71b58863f8e5da7c3dabd9d3f
	git bisect bad 1d30c33d8d07868199560b24f10ed6280e78a89c

and it should pick 

	f4d6d004: libata: ignore EH scheduling during initialization

for you to test. It will apparently break on the fact that "sata_via.c" 
wants "ata_scsi_device_resume/suspend" for the initialization of the
resume/suspend things in the scsi_host_template, but you should just 
remove those lines, and the compile hopefully completes cleanly after 
that.

IOW, it *should* be easy enough to pinpoint this from 9 changes down to 
just one.

Jeff added to the Cc, since he may not have noticed that one of the most 
long-running issues is apparently sata-related.

(Jeff: David Greaves _also_ had issues with -rc4 due to the SETFXSR 
change, but that should hopefully be resolved and is presumably an 
independent bug. Apart from the fact that "sata_via.c" seems problematic)

		Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/