linux-kernel - Re: [ckrm-tech] [RFC][PATCH 1/6] Introduce struct sched

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070612035245.GA3942@in.ibm.com>
Date:	Tue, 12 Jun 2007 09:22:45 +0530
From:	Srivatsa Vaddagiri <vatsa@...ux.vnet.ibm.com>
To:	Balbir Singh <balbir@...ux.vnet.ibm.com>
Cc:	vatsa@...ux.vnet.ibm.com, Ingo Molnar <mingo@...e.hu>,
	Nick Piggin <nickpiggin@...oo.com.au>, wli@...omorphy.com,
	ckrm-tech@...ts.sourceforge.net, balbir@...ibm.com, efault@....de,
	pwil3058@...pond.net.au, kernel@...ivas.org,
	linux-kernel@...r.kernel.org, dmitry.adamushko@...il.com,
	tingy@...umass.edu, tong.n.li@...el.com, containers@...ts.osdl.org,
	akpm@...ux-foundation.org, torvalds@...ux-foundation.org
Subject: Re: [ckrm-tech] [RFC][PATCH 1/6] Introduce struct sched_entity and struct lrq

On Tue, Jun 12, 2007 at 07:45:59AM +0530, Balbir Singh wrote:
> > +/* CFS-related fields in a runqueue */
> > +struct lrq {
> > +	unsigned long raw_weighted_load;
> > +	#define CPU_LOAD_IDX_MAX 5
> > +	unsigned long cpu_load[CPU_LOAD_IDX_MAX];
> > +	unsigned long nr_load_updates;
> > +
> > +	u64 fair_clock, delta_fair_clock;
> > +	u64 exec_clock, delta_exec_clock;
> > +	s64 wait_runtime;
> > +	unsigned long wait_runtime_overruns, wait_runtime_underruns;
> > +
> > +	struct rb_root tasks_timeline;
> > +	struct rb_node *rb_leftmost;
> > +	struct rb_node *rb_load_balance_curr;
> > +};
> > +
> 
> Shouldn't the rq->lock move into lrq?

Right now, the per-cpu rq lock protects all (local) runqueues attached with the 
cpu. At some point, for scalability reasons, we may want to split that to
be per-cpu per-local runqueue (as you point out). I will put that in my todo
list of things to consider. Thanks for the review!

-- 
Regards,
vatsa
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/