[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <46704801.1070107@garzik.org>
Date: Wed, 13 Jun 2007 15:39:45 -0400
From: Jeff Garzik <jeff@...zik.org>
To: bryan.wu@...log.com
CC: LKML <linux-kernel@...r.kernel.org>, netdev@...r.kernel.org,
torvalds@...ux-foundation.org,
Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] Blackfin ethernet driver: on chip ethernet MAC controller
driver
Bryan Wu wrote:
> From: "Wu, Bryan" <bryan.wu@...log.com>
>
> This patch implements the driver necessary use the Analog Devices
> Blackfin processor's on-chip ethernet MAC controller.
>
> Signed-off-by: Bryan Wu <bryan.wu@...log.com>
> Cc: Jeff Garzik <jeff@...zik.org>
> Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>
> ---
>
> drivers/net/Kconfig | 44 +
> drivers/net/Makefile | 1
> drivers/net/bfin_mac.c | 981 +++++++++++++++++++++++++++++++++++++++
> drivers/net/bfin_mac.h | 147 +++++
> 4 files changed, 1173 insertions(+)
Finally got back to this. Please run this patch through
scripts/checkpatch.pl (found in latest linux-2.6.git upstream kernel
tree), and follow most of the recommendations.
Personally I would ignore the lines slightly over 80 columns, but the
other warnings look like real issues.
Jeff
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists