linux-kernel - Re: [patch] sched: fix SysRq-N (normalize RT tasks)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 14 Jun 2007 20:09:46 +0100
From:	Måns Rullgård <mans@...sr.com>
To:	linux-kernel@...r.kernel.org
Subject:  Re: [patch] sched: fix SysRq-N (normalize RT tasks)

Ingo Molnar <mingo@...e.hu> writes:

> From: Ingo Molnar <mingo@...e.hu>
> Subject: [patch] sched: fix SysRq-N (normalize RT tasks)
>
> Gene Heskett reported the following problem while testing CFS: SysRq-N 
> is not always effective in normalizing tasks back to SCHED_OTHER.
>
> the reason for that turns out to be the following bug: 
> normalize_rt_tasks() uses for_each_process() to iterate through all 
> tasks in the system. The problem is, this method does not iterate 
> through all tasks, it iterates through all thread groups. The proper 
> mechanism to enumerate all tasks is to use a do_each_thread() + 
> while_each_thread() loop.

Was this always a bug or did the meaning of for_each_process() change
since this code was added?

-- 
Måns Rullgård
mans@...sr.com

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/