linux-kernel - Re: [patch 4/6] SM501 MFD driver updates

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <200706150923.11657.m.kozlowski@tuxland.pl>
Date:	Fri, 15 Jun 2007 09:23:11 +0200
From:	Mariusz Kozlowski <m.kozlowski@...land.pl>
To:	Ben Dooks <ben-linux@...ff.org>
Cc:	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org
Subject: Re: [patch 4/6] SM501 MFD driver updates

Hello,

> +static int sm501_check_clocks(struct sm501_devdata *sm)
> +{
> +	unsigned long pwrmode = readl(sm->regs + SM501_CURRENT_CLOCK);
> +	unsigned long msrc = (pwrmode & SM501_POWERMODE_M_SRC);
> +	unsigned long m1src = (pwrmode & SM501_POWERMODE_M1_SRC);
> +
> +	return ((msrc == 0 && m1src != 0) || (msrc == 0 && msrc != 0));
                                              ^^^^^^^^^^^^^^^^^^^^^^
This will always be false. Typo?

	Mariusz
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/