linux-kernel - Re: [PATCH] atmel_lcdfb: Fix wrong line

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <46725287.7020702@rfo.atmel.com>
Date:	Fri, 15 Jun 2007 10:49:11 +0200
From:	Nicolas Ferre <nicolas.ferre@....atmel.com>
To:	Haavard Skinnemoen <hskinnemoen@...el.com>,
	"Antonino A. Daplas" <adaplas@...il.com>
CC:	linux-fbdev-devel@...ts.sourceforge.net,
	Andrew Victor <andrew@...people.com>,
	Linux Kernel list <linux-kernel@...r.kernel.org>,
	Jan Altenberg <jan.altenberg@...utronix.de>,
	Patrice Vilchez <patrice.vilchez@....atmel.com>
Subject: Re: [PATCH] atmel_lcdfb: Fix wrong line_length calculation

Haavard Skinnemoen :
> As Jan Altenberg pointed out, line_length will always be 0 if
> bits_per_pixel < 8. Fix this and also make sure that we round up to
> the nearest byte.
> 
> Signed-off-by: Haavard Skinnemoen <hskinnemoen@...el.com>
> ---
> I haven't tested this with any real program that uses the frame buffer,
> but fbset seems to report sane values for line_length:

Thank you Haavard.

I have a bigger patch for all the support for STN display (tested with
mono STN display). It is based on the work from Jan Altenberg.

This bigger patch includes your modifications.

I send it right now. As a separate message.

Haavard, can you check if the compute_hozval()
function is ok on avr32 (I have reviewed with the at32ap7000 and hope 
that it is ok) ?


Regards,
-- 
Nicolas Ferre


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/