linux-kernel - Re: drm: fix radeon setparam on 32/64 bit systems.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1181897905.26853.66.camel@localhost.localdomain>
Date:	Fri, 15 Jun 2007 18:58:25 +1000
From:	Benjamin Herrenschmidt <benh@...nel.crashing.org>
To:	David Woodhouse <dwmw2@...radead.org>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Dave Airlie <airlied@...ux.ie>
Subject: Re: drm: fix radeon setparam on 32/64 bit systems.

On Fri, 2007-06-15 at 09:44 +0100, David Woodhouse wrote:
> On Fri, 2007-06-15 at 01:59 +0000, Linux Kernel Mailing List wrote:
> > Gitweb:     http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=9b01bd5b284bbf519b726b39f1352023cb5e9e69
> > Commit:     9b01bd5b284bbf519b726b39f1352023cb5e9e69
> > Parent:     dc7a93190c21edbf3ed23e678ad04f852b9cff28
> > Author:     Dave Airlie <airlied@...ux.ie>
> > AuthorDate: Sun Jun 10 16:00:27 2007 +1000
> > Committer:  Dave Airlie <airlied@...ux.ie>
> > CommitDate: Sun Jun 10 16:00:27 2007 +1000
> > 
> >     drm: fix radeon setparam on 32/64 bit systems.
> >     
> >     The alignment on 64-bit is different for 64-bit values.
> 
> Only on i386. I think you just broke ppc32-on-ppc64.

Indeed... I'm pretty sure the 64 bits quantity will be naturally aligned
on ppc32 (and possibly others).

Ben.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/