linux-kernel - Re: RFC: Re: PATCH: udf fs corruption on linux-2.6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070615160944.GA29775@duck.suse.cz>
Date:	Fri, 15 Jun 2007 18:09:44 +0200
From:	Jan Kara <jack@...e.cz>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	Rich Coe <Richard.Coe@....ge.com>, linux-kernel@...r.kernel.org
Subject: Re: RFC: Re: PATCH: udf fs corruption on linux-2.6

On Thu 14-06-07 15:12:58, Linus Torvalds wrote:
> 
> 
> On Thu, 14 Jun 2007, Rich Coe wrote:
> >
> > I've updated the patch below to use drop_inode rather than put_inode.
> > 
> > drop_inode is only called when the last iput() reference to the inode is
> > released, where put_inode is called for every iput().
> 
> Patch looks fine, but this late in the -rc series, I'd really like to get 
> an ACK from Jan or somebody else, just to make sure there are no other 
> issues with it.
> 
> Jan? 
  My fix for this problem is already sitting in Andrew's patch queue
(http://lkml.org/lkml/2007/6/11/79). Rich's patch still has a problem - you
cannot call udf_discard_prealloc() from drop_inode() because it is called
under inode_lock and thus you cannot call e.g. mark_inode_dirty(). I've done
that mistake too ;). So please don't apply the patch.

								Honza
-- 
Jan Kara <jack@...e.cz>
SuSE CR Labs
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/