linux-kernel - Re: [patch] CFS scheduler, -v17

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20070615193515.GB24881@elte.hu>
Date:	Fri, 15 Jun 2007 21:35:16 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Ludovic Vaugeois-Pepin <ludovicvp@...il.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [patch] CFS scheduler, -v17


* Ludovic Vaugeois-Pepin <ludovicvp@...il.com> wrote:

> >kernel/built-in.o:sched.c:(.text+0x407b): more undefined references to
> >`cpu_of' follow
> >make: *** [.tmp_vmlinux1] Error 1
> >
> >I attached the .config file (config-2.6.22-rc4-cfs17)
> >
> >--
> >Ludovic Vaugeois-Pepin
> >
> >
> 
> Here is the config :

thx - this too has !CONFIG_SMP - please apply the fix below or 
re-download the v17 patch.

	Ingo

Index: linux-cfs-2.6.22-rc4.q/kernel/sched.c
===================================================================
--- linux-cfs-2.6.22-rc4.q.orig/kernel/sched.c
+++ linux-cfs-2.6.22-rc4.q/kernel/sched.c
@@ -248,6 +249,15 @@ static unsigned int static_prio_timeslic
 		return SCALE_PRIO(DEF_TIMESLICE, static_prio);
 }
 
+static inline int cpu_of(struct rq *rq)
+{
+#ifdef CONFIG_SMP
+	return rq->cpu;
+#else
+	return 0;
+#endif
+}
+
 #ifdef CONFIG_SMP
 /*
  * Divide a load by a sched group cpu_power : (load / sg->__cpu_power)
@@ -258,15 +268,6 @@ static inline u32 sg_div_cpu_power(const
 	return reciprocal_divide(load, sg->reciprocal_cpu_power);
 }
 
-static inline int cpu_of(struct rq *rq)
-{
-#ifdef CONFIG_SMP
-	return rq->cpu;
-#else
-	return 0;
-#endif
-}
-
 /*
  * Each time a sched group cpu_power is changed,
  * we must compute its reciprocal value
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/