linux-kernel - [RFC: 2.6 patch] drivers/acpi/sbs.c: remove dead code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20070615214525.GN3588@stusta.de>
Date:	Fri, 15 Jun 2007 23:45:25 +0200
From:	Adrian Bunk <bunk@...sta.de>
To:	Vladimir Lebedev <vladimir.p.lebedev@...el.com>,
	Len Brown <len.brown@...el.com>
Cc:	linux-kernel@...r.kernel.org, linux-acpi@...r.kernel.org
Subject: [RFC: 2.6 patch] drivers/acpi/sbs.c: remove dead code

This patch removes dead code spotted by the Coverity checker.

Signed-off-by: Adrian Bunk <bunk@...sta.de>

---

 drivers/acpi/sbs.c |    6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

--- linux-2.6.22-rc4-mm2/drivers/acpi/sbs.c.old	2007-06-15 22:44:17.000000000 +0200
+++ linux-2.6.22-rc4-mm2/drivers/acpi/sbs.c	2007-06-15 22:46:26.000000000 +0200
@@ -1411,7 +1411,7 @@ static int acpi_sbs_update_run(struct ac
 	char dir_name[32];
 	int do_battery_init = 0, do_ac_init = 0;
 	int old_remaining_capacity = 0;
-	int update_ac = 1, update_battery = 1;
+	int update_battery = 1;
 	int up_tm = update_time;
 
 	if (sbs_zombie(sbs)) {
@@ -1431,10 +1431,6 @@ static int acpi_sbs_update_run(struct ac
 
 	sbs->run_cnt++;
 
-	if (!update_ac && !update_battery) {
-		goto end;
-	}
-
 	old_ac_present = sbs->ac.ac_present;
 
 	result = acpi_ac_get_present(sbs);

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/