linux-kernel - Re: [PATCH] natsemi irq flags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <46730D82.7020508@redhat.com>
Date:	Fri, 15 Jun 2007 18:06:58 -0400
From:	Chuck Ebbert <cebbert@...hat.com>
To:	Gregory Haskins <ghaskins@...ell.com>
CC:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] natsemi irq flags

On 06/15/2007 05:17 PM, Gregory Haskins wrote:
> The spinlock irq flags should be a unsigned long to properly support 64 bit

Ouch. Can't we automate checking for that?

> 
> Signed-off-by: Gregory Haskins <ghaskins@...ell.com>
> 
> ---
> 
>  drivers/net/natsemi.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/net/natsemi.c b/drivers/net/natsemi.c
> index 4cf0d3f..460a087 100644
> --- a/drivers/net/natsemi.c
> +++ b/drivers/net/natsemi.c
> @@ -690,7 +690,7 @@ static ssize_t natsemi_set_dspcfg_workaround(struct device *dev,
>  {
>  	struct netdev_private *np = netdev_priv(to_net_dev(dev));
>  	int new_setting;
> -	u32 flags;
> +	unsigned long flags;
>  
>          /* Find out the new setting */
>          if (!strncmp("on", buf, count - 1) || !strncmp("1", buf, count - 1))
> 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/