[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <20070617234254.GD3588@stusta.de>
Date: Mon, 18 Jun 2007 01:42:54 +0200
From: Adrian Bunk <bunk@...sta.de>
To: Tejun Heo <htejun@...il.com>
Cc: Jeff Garzik <jeff@...zik.org>, linux-kernel@...r.kernel.org
Subject: [2.6 patch] fix devres_release_all() return value
Every file should include the headers containing the prototypes for
it's global functions.
Since the GNU C compiler is now able to detect that the function
prototype of devres_release_all() in the header and the actual function
disagree regarding the return value, this patch also fixes this bug.
Signed-off-by: Adrian Bunk <bunk@...sta.de>
---
drivers/base/base.h | 2 +-
drivers/base/devres.c | 2 ++
2 files changed, 3 insertions(+), 1 deletion(-)
--- linux-2.6.22-rc4-mm2/drivers/base/base.h.old 2007-06-17 15:37:21.000000000 +0200
+++ linux-2.6.22-rc4-mm2/drivers/base/base.h 2007-06-17 15:37:34.000000000 +0200
@@ -44,6 +44,6 @@
extern char *make_class_name(const char *name, struct kobject *kobj);
-extern void devres_release_all(struct device *dev);
+extern int devres_release_all(struct device *dev);
extern struct kset devices_subsys;
--- linux-2.6.22-rc4-mm2/drivers/base/devres.c.old 2007-06-17 15:30:48.000000000 +0200
+++ linux-2.6.22-rc4-mm2/drivers/base/devres.c 2007-06-17 15:31:03.000000000 +0200
@@ -10,6 +10,8 @@
#include <linux/device.h>
#include <linux/module.h>
+#include "base.h"
+
struct devres_node {
struct list_head entry;
dr_release_t release;
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists