linux-kernel - Re: [PATCH 1/2] kvm: Fix x86 emulator writeback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <46765954.60102@qumranet.com>
Date:	Mon, 18 Jun 2007 13:07:16 +0300
From:	Avi Kivity <avi@...ranet.com>
To:	Luca Tettamanti <kronos.it@...il.com>
CC:	kvm-devel@...ts.sourceforge.net, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] kvm: Fix x86 emulator writeback

Luca Tettamanti wrote:
> When the old value and new one are the same the emulator skips the
> write; this is undesiderable when the destination is a MMIO area and the
> write shall be performed regardless of the previous value. This
> optimization breaks e.g. a Linux guest APIC compiled without
> X86_GOOD_APIC.
>
> Remove the check and always perform the writeback stage in the
> emulation.
>
>   

Unfortunately, this kills Windows XP (first run with a guest crash, 
second with a host oops), so I reverted it.  I'd guess some operation  
which doesn't need writeback ends up in the modified code.  Previously, 
the check caused it to skip writeback, but now it writes back random 
memory, causing a crash.

-- 
error compiling committee.c: too many arguments to function

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/